Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multipolygon support #305

Merged
merged 15 commits into from
Jun 19, 2018
Merged

Multipolygon support #305

merged 15 commits into from
Jun 19, 2018

Conversation

codeofsumit
Copy link
Contributor

@codeofsumit codeofsumit commented Jun 15, 2018 •
edited
Loading

this is an open PR that is not 100% finished yet. But I'm working on Multipolygon & Multipolyline support.
I'd like to make support as robust as possible without hard coded array depths or flattening.
Wish me luck 🤞

Will fix #143, fix #249, close #279, close #293

UPDATE:
This PR is quite far: I'd love to have some developers test it with their apps and data.

@codeofsumit
Copy link
Contributor Author

current status:
multipolygons can be added to leaflet.pm, vertexes edited, added and removed 🎉

@codeofsumit
Copy link
Contributor Author

codeofsumit commented Jun 16, 2018 •
edited
Loading

drag and snap to other layers works now too.

multipoly

@codeofsumit
Copy link
Contributor Author

Cutting with MultiPolygon Support

cut multypoly

@codeofsumit
Copy link
Contributor Author

@mpschaeuble, @smeijer, I'd love to get some feedback on this. Could you test this branch with your data and apps for MultiPolygon and MultiPolyline support?

@codeofsumit codeofsumit merged commit 630a712 into develop Jun 19, 2018
@codeofsumit codeofsumit deleted the multipolygon-support branch June 22, 2018 12:44
@smeijer
Copy link

smeijer commented Jul 4, 2018

Sorry for the late response.

The latest version with this PR merged seems to be working just fine. Awesome work!

Thanks. 🎉

@jdk-creator
Copy link

i have the same issue with the multipolygon when i load the ressources from my server then transform the ressources in geojson format then try to edit by clicking on the multipolygon in the map

@codeofsumit
Copy link
Contributor Author

@adamsjoe96 please open a new issue and describe exactly the problem you have.
From your comment here it looks like you want to edit your polygon by clicking on it? If so, you have to add a click event to the polygon and enable edit in the click handler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: Cannot read property 'lat' of null Add support for Multipolylines
3 participants
@codeofsumit @smeijer @jdk-creator